Category: 小小草

Magento 1.5 以后就允许修改订单地址了，Plieninger_Editable module 就没必要存在了，留着它反而会出错。

当年想找一个修改订单地址的方案，就找到了 Plieninger_Editable，一用就用了一年。虽然一直不满意它的界面，一直想自己写一个，但一直忙于其他事务。现在跟它说 bye bye，还是很感谢它的。

Where and how to change the code?

At first, I thought overriding Mage_Catalog_Model_Product_Type_Configurable::getOrderOptions().
Original code

$options['product_calculations'] = self::CALCULATE_PARENT;

change to

$options['product_calculations'] = self::CALCULATE_CHILD;

However, it does not work.

Then I tried to observe the event tax_rate_data_fetch and modify the rateRequest object. But inside rateRequest there is no reference to quoteItem. Only product tax_class_id is there. In the observer class, I do not know when to modify it without reference to quoteItem.

At last, I had to modify the code in class Mage_Tax_Model_Sales_Total_Quote_Tax. There are several places to change depends on System Configuration. Change where is appropriate.
Original code

$taxRateRequest->setProductClassId($item->getProduct()->getTaxClassId());

change to

if ($item->getProductType() == Mage_Catalog_Model_Product_Type::TYPE_CONFIGURABLE) {
	$child = current($item->getChildren());
	$taxRateRequest->setProductClassId($child->getProduct()->getTaxClassId());
}
else {
	$taxRateRequest->setProductClassId($item->getProduct()->getTaxClassId());
}

It is not a neat approach. Let me know if you have a better idea.

Magento 里还是有不少 bugs，我能看出来的就不少。可是我一直懒于 report bug，总觉得我都能发现的 bug，大把有人发现。

今天心血来潮，大概受“莫以善小而不为”驱使，平生第一次 report bug to Magento。事关 js/mage/adminhtml/product.js 文件里第406 行（Magento 1.5.0.1）, 有个笔误，把 readonly 写成了redonly。Associated Products tab of Configurable Products 受此影响，本应只读模式的文本框仍可输入数据。

非常小的错误。

今后我把我的发现记载下来。